linux-kernel - RE: [PATCH] LP3971 PMIC regulator driver update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <000601c9d7ac$58af73d0$0a0e5b70$%szyprowski@samsung.com>
Date:	Mon, 18 May 2009 13:32:32 +0200
From:	Marek Szyprowski <m.szyprowski@...sung.com>
To:	'Liam Girdwood' <lrg@...mlogic.co.uk>
Cc:	linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.arm.linux.org.uk, kyungmin.park@...sung.com,
	'Mark Brown' <mark.brown@...fsonmicro.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: RE: [PATCH] LP3971 PMIC regulator driver update

Hello, 

On Monday, May 18, 2009 12:15 PM Liam Girdwood wrote:

> On Fri, 2009-05-15 at 10:20 +0100, Mark Brown wrote:
> > On Fri, May 15, 2009 at 11:16:19AM +0200, Marek Szyprowski wrote:
> > > This patch fixes issues reported by Mark Brown in his review of
> National Semiconductors LP3971
> > > PMIC regulator driver. It contains:
> > > - a little code cleanup
> > > - list_voltage() callback added
> >
> > > Reviewed-by: Kyungmin Park <kyungmin.park@...sung.com>
> > > Signed-off-by: Marek Szyprowski <m.szyprowski@...sung.com>
> >
> > Looks good.
> >
> > Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>
> 
> Doesn't apply :-
> 
> Applying: LP3971 PMIC regulator driver update
> error: patch failed: drivers/regulator/lp3971.c:91
> error: drivers/regulator/lp3971.c: patch does not apply
> Patch failed at 0001 LP3971 PMIC regulator driver update
> 
> Could you regenerate against the voltage for-next branch.

I've checked the
git://git.kernel.org/pub/scm/linux/kernel/git/lrg/voltage-2.6.git, the
for-next branch. I looks that all tabs are converted to spaces in my
previous patch. I've checked again it imho I've posted it properly. Maybe it
was broken by merge conflicts in Makefile/Kconfig. What should I do in such
case? Would you revert the broken version or do I need to post a patch for
it?

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/