linux-kernel - Re: [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A1164D4.8000509@ru.mvista.com>
Date:	Mon, 18 May 2009 17:38:28 +0400
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Krzysztof Halasa <khc@...waw.pl>
Cc:	Joe Perches <joe@...ches.com>,
	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	Borislav Petkov <petkovbb@...il.com>
Subject: Re: [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice(

Hello.

Krzysztof Halasa wrote:

>>>  			} else {
>>>  				floppy->blocks = blocks;
>>>  				floppy->block_size = length;
>>>  				floppy->bs_factor = length / 512;
>>>  				if (floppy->bs_factor != 1)
>>> -					printk(KERN_NOTICE PFX "%s: Warning: "
>>> -					       "non 512 bytes block size not "
>>> -					       "fully supported\n",
>>> -					       drive->name);
>>> +					pr_notice(PFX "%s: Warning: non 512 bytes block size not fully supported\n",
>>>   
>>>       
>>   Again.
>>     
>
> (> 80 chars in line)
>
> Though I think most people would agree that the latter is much better,
> no?
>   

   Don't know about most people but I don't find 120-column lines better 
(being recently imposed 65-column limit on the patch description by some 
people :-).

> I think removal (rewording) of this rule has already been agreed upon,
> though not exactly yet codified.
>   

   Again, don't know about that but that would be against my personal 
preference. Also, if still not codified, it won't pass chackpatch.pl, so 
should be fixed.

MBR, Sergei


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/