linux-kernel - Re: [PATCH] Fix print out of function which called WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A116CA3.4050902@linux.intel.com>
Date:	Mon, 18 May 2009 07:11:47 -0700
From:	Arjan van de Ven <arjan@...ux.intel.com>
To:	Ian Campbell <Ian.Campbell@...rix.com>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andi Kleen <ak@...ux.intel.com>,
	Jakub Jelinek <jakub@...hat.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jesper Nilsson <jesper.nilsson@...s.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Hugh Dickins <hugh@...itas.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Fix print out of function which called WARN_ON()

Ian Campbell wrote:
> On Sat, 2009-05-16 at 13:47 -0700, Linus Torvalds wrote:
> 
>>  - it uses '%pS' instead of of sprint_symbol
> [...]
>> -       printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file,
>> -               line, function);
>> +	printk(KERN_WARNING "WARNING: at %s:%d %pS()\n", file, line, caller);
> 
> Those parens end up looking pretty odd to me with the %pS:
> 	WARNING: at [...] local_bh_enable+0x68/0x80()

didn't we have a %pSomething that doesn't print those 2 hex parts ?
(It would allow us to keep the print format the same)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/