linux-kernel - Re: [PATCH] ftrace:fix check for return value of register_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090518142507.GE4704@nowhere>
Date:	Mon, 18 May 2009 16:25:11 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Ming Lei <tom.leiming@...il.com>
Cc:	Li Zefan <lizf@...fujitsu.com>, rostedt@...dmis.org,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org,
	mingo@...e.hu
Subject: Re: [PATCH] ftrace:fix check for return value of
	register_module_notifier

On Mon, May 18, 2009 at 08:39:57PM +0800, Ming Lei wrote:
> From d0d91950165f1d0a05ce8f68b333c6f0724b0007 Mon Sep 17 00:00:00 2001
> From: Ming Lei <tom.leiming@...il.com>
> Date: Sun, 17 May 2009 15:26:28 +0800
> Subject: [PATCH] ftrace:fix check for return value of register_module_notifier(v2)
> 
> return zero should be correct, so fix it.
> 
> Signed-off-by: Ming Lei <tom.leiming@...il.com>
> Signed-off-by: Li Zefan <lizf@...fujitsu.com>

Hi,


You are making a confusion between Signed-off-by: and
Reported-by:

Indeed Li Zefan suggested you to expand your patch to fix
another place. And that's what you did in this patch, that's fine.

But Signed-off-by: has a special meaning, please read the
Developer's Certificate of Origin 1.1 in Documentation/SubmittingPatches.

You shoudn't add someone else Signed-off-by if he/she didn't gave it to
you.

Instead, if you implement in a v2 patch a suggestion someone made while
reviewing your v1 patch, you can credit him in the changelog:

v2: change foo, as suggested by li Zefan

And if it's a new patch that addresses a new review, you can
just put a Reported-by: tag.


Your first patch have been applied in tip:/tracing/core topic.
So could you please send a new patch which addresses only
the event_trace_init() callsite?

You can add the

Reported-by: Li Zefan <lizf@...fujitsu.com>

and also my

Acked-by: Frederic Weisbecker <fweisbec@...il.com>

in advance.

Thanks Ming!

Frederic.

> Acked-by: Frederic Weisbecker <fweisbec@...il.com> 
> ---
>  kernel/trace/ftrace.c       |    2 +-
>  kernel/trace/trace_events.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index 5b606f4..140699a 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -2826,7 +2826,7 @@ void __init ftrace_init(void)
>  				  __stop_mcount_loc);
>  
>  	ret = register_module_notifier(&ftrace_module_nb);
> -	if (!ret)
> +	if (ret)
>  		pr_warning("Failed to register trace ftrace module notifier\n");
>  
>  	return;
> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> index 0eec0c5..9e91c4a 100644
> --- a/kernel/trace/trace_events.c
> +++ b/kernel/trace/trace_events.c
> @@ -1174,7 +1174,7 @@ static __init int event_trace_init(void)
>  	}
>  
>  	ret = register_module_notifier(&trace_module_nb);
> -	if (!ret)
> +	if (ret)
>  		pr_warning("Failed to register trace events module notifier\n");
>  
>  	return 0;
> -- 
> 1.6.0.GIT
> 
> 
> 
> -- 
> Lei Ming
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/