linux-kernel - Re: [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3octqib2b.fsf@intrepid.localdomain>
Date:	Mon, 18 May 2009 19:18:52 +0200
From:	Krzysztof Halasa <khc@...waw.pl>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	Sergei Shtylyov <sshtylyov@...mvista.com>,
	Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
	linux-ide@...r.kernel.org, Borislav Petkov <petkovbb@...il.com>
Subject: Re: [PATCH 6/6] drivers/ide: Convert printk(KERN_NOTICE to pr_notice(

Bartlomiej Zolnierkiewicz <bzolnier@...il.com> writes:

>> Though I think most people would agree that the latter is much better,
>> no?
>
> No, it just hides the real issue:

I didn't say it's best. Just better :-)

>> I think removal (rewording) of this rule has already been agreed upon,
>> though not exactly yet codified.
>
> This is not a strict rule but in 99% cases it shows that the code could
> be improved further without >80 chars lines.

I don't have the stat numbers handy but the established idea is that
since the texts could be up to 80-chars long (and it's a good thing),
the printk line needed to output them has to be longer.
IOW, breaking the text into pieces is worse. Obviously, that doesn't
mean one can't do better.
-- 
Krzysztof Halasa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/