linux-kernel - Re: iwlagn broken in next-20090514 and next-20090515

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1242670211.29049.10.camel@johannes.local>
Date:	Mon, 18 May 2009 20:10:11 +0200
From:	Johannes Berg <johannes@...solutions.net>
To:	Dan Williams <dcbw@...hat.com>
Cc:	reinette chatre <reinette.chatre@...el.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	Nico -telmich- Schottelius <nico-linux-next@...ottelius.org>,
	"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"John W. Linville" <linville@...driver.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>
Subject: Re: iwlagn broken in next-20090514 and next-20090515

On Mon, 2009-05-18 at 13:50 -0400, Dan Williams wrote:

> > > > > Also wpa_supplicant is not happy:
> > > > > 
> > > > > + wpa_supplicant -B -Dwext -iwlan0 -c /home/user/nico/ethz/wlan/wpa_supplicant.conf
> > > > > ioctl[SIOCSIWENCODEEXT]: No such file or directory
> > > > > ioctl[SIOCSIWENCODEEXT]: No such file or directory
> > > > > ioctl[SIOCSIWENCODEEXT]: No such file or directory
> > > > > ioctl[SIOCSIWENCODEEXT]: No such file or directory
> > > > > 
> > > 
> > > There were some changes recently to this ioctl, but I am not familiar
> > > with details. Johannes will know.
> > 
> > Yeah, I'm not sure -- this happens when clearing keys. I'll look into
> > it, we probably need to accept removing a key that doesn't exist.
> 
> Why bother (if that's actually the root cause)?  Maybe the supplicant
> should be fixed.  Other drivers return ENOENT in this case, so mac80211
> certainly isn't out-of-common-spec here now.

I just looked at the code in wpa_supplicant, it doesn't care a bit, just
prints the error. Problem is users attribute any other breakage to the
error it prints since our behaviour changed...

johannes

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)