linux-kernel - Re: [Openipmi-developer] modprobe ipmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20090518184053.GA24134@minyard.local>
Date:	Mon, 18 May 2009 13:40:54 -0500
From:	Corey Minyard <minyard@....org>
To:	Ferenc Wagner <wferi@...f.hu>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	openipmi-developer@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org
Subject: Re: [Openipmi-developer] modprobe ipmi_si hangs under 2.6.30-rc5

On Mon, May 18, 2009 at 07:33:23PM +0200, Ferenc Wagner wrote:
> Andrew Morton <akpm@...ux-foundation.org> writes:
> 
> > Well there have only been a handful of changes to ipmi since 2.6.29. 
> > Could you try a mini-bisection?
> >
> > Apply revert-1.patch, test
> > Apply revert-2.patch, test
> > Apply revert-3.patch, test
> > Apply revert-4.patch, test
> 
> After applying revert-1.patch, modprobe runs OK:
> 
> [   86.968156] IPMI System Interface driver.
> [   86.976276] ipmi_si: Trying SMBIOS-specified smic state machine at i/o address 0xecf4, slave address 0x20, irq 0
> [   87.117630] ipmi: Found new BMC (man_id: 0x0002a2,  prod_id: 0x0000, dev_id: 0x00)
> [   87.133078] IPMI smic interface initialized
> 
> I guess there's no point in trying the rest.

I think I see the problem.  Can you try the patch at the end of the
email?  I can't test it because I don't have an IPMI 1.0 sytem.
Thanks for setting up the mini-bisection, Andrew.

> 
> When loading with debug options, it still produces insane amount of
> debug messages continuously (first 671 lines of it attached).

Yes, full debugging generates a ton of output, it logs everything it does
in that case.

Thanks,

-corey


Set the current channel to the number of channels in an IPMI 1.0 system,
as this value is used to tell if the channel information has been
initialized.

Signed-off-by: Corey Minyard <cminyard@...sta.com>

diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c
index aa83a08..48f4269 100644
--- a/drivers/char/ipmi/ipmi_msghandler.c
+++ b/drivers/char/ipmi/ipmi_msghandler.c
@@ -2856,6 +2856,7 @@ int ipmi_register_smi(struct ipmi_smi_handlers *handlers,
 		/* Assume a single IPMB channel at zero. */
 		intf->channels[0].medium = IPMI_CHANNEL_MEDIUM_IPMB;
 		intf->channels[0].protocol = IPMI_CHANNEL_PROTOCOL_IPMB;
+		intf->curr_channel = 1;
 	}
 
 	if (rv == 0)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/