lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 May 2009 05:39:48 GMT From: tip-bot for Paul Mackerras <paulus@...ba.org> To: linux-tip-commits@...r.kernel.org Cc: linux-kernel@...r.kernel.org, paulus@...ba.org, hpa@...or.com, mingo@...hat.com, a.p.zijlstra@...llo.nl, tglx@...utronix.de, cjashfor@...ux.vnet.ibm.com, mingo@...e.hu Subject: [tip:perfcounters/core] perf_counter: powerpc: initialize cpuhw pointer before use Commit-ID: c0daaf3f1f672defa3a45ca449b76d0e86c55892 Gitweb: http://git.kernel.org/tip/c0daaf3f1f672defa3a45ca449b76d0e86c55892 Author: Paul Mackerras <paulus@...ba.org> AuthorDate: Mon, 18 May 2009 14:02:12 +1000 Committer: Ingo Molnar <mingo@...e.hu> CommitDate: Mon, 18 May 2009 07:38:42 +0200 perf_counter: powerpc: initialize cpuhw pointer before use Commit 9e35ad38 ("perf_counter: Rework the perf counter disable/enable") added code to the powerpc hw_perf_enable (renamed from hw_perf_restore) to test cpuhw->disabled and return immediately if it is not set (i.e. if the PMU is already enabled). Unfortunately the test got added before cpuhw was initialized, resulting in an oops the first time hw_perf_enable got called. This fixes it by moving the initialization of cpuhw to before cpuhw->disabled is tested. [ Impact: fix oops-causing bug on powerpc ] Signed-off-by: Paul Mackerras <paulus@...ba.org> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl> Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com> LKML-Reference: <18960.56772.869734.304631@...ngo.ozlabs.ibm.com> Signed-off-by: Ingo Molnar <mingo@...e.hu> --- arch/powerpc/kernel/perf_counter.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/perf_counter.c b/arch/powerpc/kernel/perf_counter.c index 6baae5a..fe21b24 100644 --- a/arch/powerpc/kernel/perf_counter.c +++ b/arch/powerpc/kernel/perf_counter.c @@ -450,12 +450,11 @@ void hw_perf_enable(void) int idx; local_irq_save(flags); + cpuhw = &__get_cpu_var(cpu_hw_counters); if (!cpuhw->disabled) { local_irq_restore(flags); return; } - - cpuhw = &__get_cpu_var(cpu_hw_counters); cpuhw->disabled = 0; /* -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists