linux-kernel - Re: [PATCH] ftrace:fix check for return value of register_module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d82e647a0905171840v58eed575s2ce2dd6914f5479@mail.gmail.com>
Date:	Mon, 18 May 2009 09:40:14 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	Li Zefan <lizf@...fujitsu.com>
Cc:	rostedt@...dmis.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, mingo@...e.hu
Subject: Re: [PATCH] ftrace:fix check for return value of register_module_notifier

2009/5/18 Li Zefan <lizf@...fujitsu.com>:
> tom.leiming@...il.com wrote:
>> From: Ming Lei <tom.leiming@...il.com>
>>
>> return zero should be correct, so fix it.
>>
>
> Nice catch.
>
> We have those bogus warnings:
>
>  $ dmesg | grep Failed
>  Failed to register trace ftrace module notifier
>  Failed to register trace events module notifier
>
> Could you fix the same bug in event_trace_init()?

OK, I'll submit it later.

>
>> Signed-off-by: Ming Lei <tom.leiming@...il.com>
>> ---
>>  kernel/trace/ftrace.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
>> index 5b606f4..140699a 100644
>> --- a/kernel/trace/ftrace.c
>> +++ b/kernel/trace/ftrace.c
>> @@ -2826,7 +2826,7 @@ void __init ftrace_init(void)
>>                                 __stop_mcount_loc);
>>
>>       ret = register_module_notifier(&ftrace_module_nb);
>> -     if (!ret)
>> +     if (ret)
>>               pr_warning("Failed to register trace ftrace module notifier\n");
>>
>>       return;
>



-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/