linux-kernel - Re: [PATCH] regulator: da903x: add missing __devexit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f17812d70905180112h6fdff033h2235919ca2f29987@mail.gmail.com>
Date:	Mon, 18 May 2009 16:12:36 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	Mike Rapoport <mike@...pulab.co.il>,
	Eric Miao <eric.miao@...vell.com>
Subject: Re: [PATCH] regulator: da903x: add missing __devexit_p()

On Sat, May 16, 2009 at 2:50 AM, Mike Frysinger <vapier@...too.org> wrote:
> The remove function uses __devexit, so the .remove assignment needs
> __devexit_p() to fix a build error with hotplug disabled.
>
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> CC: Liam Girdwood <lrg@...mlogic.co.uk>
> CC: Mike Rapoport <mike@...pulab.co.il>
> CC: Eric Miao <eric.miao@...vell.com>

Yes, Acked.

> ---
>  drivers/regulator/da903x.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/regulator/da903x.c b/drivers/regulator/da903x.c
> index 72b1549..c6628f5 100644
> --- a/drivers/regulator/da903x.c
> +++ b/drivers/regulator/da903x.c
> @@ -497,7 +497,7 @@ static struct platform_driver da903x_regulator_driver = {
>                .owner  = THIS_MODULE,
>        },
>        .probe          = da903x_regulator_probe,
> -       .remove         = da903x_regulator_remove,
> +       .remove         = __devexit_p(da903x_regulator_remove),
>  };
>
>  static int __init da903x_regulator_init(void)
> --
> 1.6.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/