linux-kernel - Re: [PATCH] [SQUASHME] "FC Pass Thru support" fixed for block/for-2.6.31 tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A12868E.6030108@panasas.com>
Date:	Tue, 19 May 2009 13:14:38 +0300
From:	Boaz Harrosh <bharrosh@...asas.com>
To:	Tejun Heo <tj@...nel.org>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>,
	James Smart <James.Smart@...lex.Com>,
	James Bottomley <James.Bottomley@...senpartnership.com>,
	linux-scsi <linux-scsi@...r.kernel.org>,
	FUJITA Tomonori <tomof@....org>,
	Linux Kernel <linux-kernel@...r.kernel.org>,
	Jens Axboe <Jens.Axboe@...cle.com>
Subject: Re: [PATCH] [SQUASHME] "FC Pass Thru support" fixed for block/for-2.6.31
 tree

On 05/19/2009 01:05 PM, Tejun Heo wrote:
> Hello, Boaz.
> 
> Just two minor things.
> 
> Boaz Harrosh wrote:
>>  	/* we assume all request payload was transferred, residual == 0 */
>> -	req->data_len = 0;
>> +	req->resid_len = 0;
>>  
>>  	if (rsp) {
>> -		rsp_len = blk_rq_bytes(rsp);
>> -		BUG_ON(job->reply->reply_payload_rcv_len > rsp_len);
> 
> Maybe convert it to WARN_ON() instead of removing?

Sorry, You are absolutely correct should add it back. (With a WARN_ON)

> 
>>  		/* set reply (bidi) residual */
>> -		rsp->data_len = (rsp_len - job->reply->reply_payload_rcv_len);
>> +		rsp->resid_len = blk_rq_bytes(rsp) -
>> +					job->reply->reply_payload_rcv_len;
> 
> With the fix-fallouts patchset it, this can be
> 
> 	rsp->resid_len -= job->reply->reply_payload_rcv_len;
> 

Sure.

> Other than above misc points,
> 
> Acked-by: Tejun Heo <tj@...nel.org>
> 

Will repost as reply to Original patch, thanks
Boaz
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/