linux-kernel - Re: [PATCH 3/3] vmscan: merge duplicate code in shrink_active

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090519103253.GA2667@localhost>
Date:	Tue, 19 May 2009 18:32:53 +0800
From:	Wu Fengguang <fengguang.wu@...el.com>
To:	Johannes Weiner <hannes@...xchg.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	"riel@...hat.com" <riel@...hat.com>,
	"tytso@....edu" <tytso@....edu>,
	"linux-mm@...ck.org" <linux-mm@...ck.org>,
	"elladan@...imo.com" <elladan@...imo.com>,
	"npiggin@...e.de" <npiggin@...e.de>,
	"minchan.kim@...il.com" <minchan.kim@...il.com>
Subject: Re: [PATCH 3/3] vmscan: merge duplicate code in
	shrink_active_list()

On Tue, May 19, 2009 at 06:18:33PM +0800, Johannes Weiner wrote:
> On Tue, May 19, 2009 at 10:43:16AM +0800, Wu Fengguang wrote:
> > @@ -1283,6 +1319,7 @@ static void shrink_active_list(unsigned 
> >  			 * are ignored, since JVM can create lots of anon
> >  			 * VM_EXEC pages.
> >  			 */
> > +			if (page_cluster)
> >  			if ((vm_flags & VM_EXEC) && !PageAnon(page)) {
> >  				list_add(&page->lru, &l_active);
> >  				continue;
> 
> Huh, what's with that hunk?

Ah, sorry, that's a handy debugging knob ;)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/