linux-kernel - Re: [PATCH] ath5k: prevent infinite loop

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090519123422.GE2580@hash.localnet>
Date:	Tue, 19 May 2009 08:34:22 -0400
From:	Bob Copeland <me@...copeland.com>
To:	Steven Rostedt <rostedt@...dmis.org>
Cc:	Nick Kossifidis <mickflemm@...il.com>,
	LKML <linux-kernel@...r.kernel.org>, jirislaby@...il.com,
	lrodriguez@...eros.com, linux-wireless@...r.kernel.org,
	ath5k-devel@...ts.ath5k.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] ath5k: prevent infinite loop

On Tue, May 19, 2009 at 07:54:23AM -0400, Steven Rostedt wrote:
> > Do these patches need to go to 2.6.30?
> 
> Considering that it locked up my box, I would think that it should. Well, 
> at least the change that checks for the infinite loop.

Yeah, I just wasn't sure if you were using that or -next (which should be
fixed, I guess.)  I mistakenly thought Nick posted commit ishs but they
were blobs, the actual commit was:

e5f1d7f3c192c8ebeb492427bab84611ed5568eb "ath5k: fix interpolation with
equal power levels" in wireless-testing.

Those loops really want a helper function...

Hmm, not too familiar with this particular code but getting back -32768
in the degenerate case seems wrong so I'd be inclined towards a hybrid
version of the two that also sanity checks the steps (corrupt eeproms
are bad, but one rather likely corruption is a big block of ones or 
zeroes).

-- 
Bob Copeland %% www.bobcopeland.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/