linux-kernel - Re: [PATCH 2/2]cpuidle: makes AMD C1E works in suspend/resume path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.0905191456050.5983@localhost.localdomain>
Date:	Tue, 19 May 2009 15:07:08 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Shaohua Li <shaohua.li@...el.com>
cc:	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
	mingo@...hat.com, thisistempbox@...oo.com, lenb@...nel.org
Subject: Re: [PATCH 2/2]cpuidle: makes AMD C1E works in suspend/resume path

On Tue, 19 May 2009, Shaohua Li wrote:

> When AMD C1E is enabled, local APIC timer will stop even in C1. To avoid
> suspend/resume hang, this patch removes C1 and replace it with a cpu_relax() in
> suspend/resume path. This hasn't any impact in runtime path.
> 
> http://bugzilla.kernel.org/show_bug.cgi?id=13233
> 
> [ impact: avoid suspend/resume hang in AMD CPU with C1E enabled ]
> 
> Tested-by: Dmitry Lyzhyn <thisistempbox@...oo.com>
> Signed-off-by: Shaohua Li <shaohua.li@...el.com>
> ---
>  drivers/acpi/processor_idle.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Index: linux/drivers/acpi/processor_idle.c
> ===================================================================
> --- linux.orig/drivers/acpi/processor_idle.c	2009-05-19 09:56:59.000000000 +0800
> +++ linux/drivers/acpi/processor_idle.c	2009-05-19 10:01:23.000000000 +0800
> @@ -834,8 +834,8 @@ static int acpi_idle_enter_c1(struct cpu
>  
>  	/* Do not access any ACPI IO ports in suspend path */
>  	if (acpi_idle_suspend) {
> -		acpi_safe_halt();
>  		local_irq_enable();
> +		cpu_relax();
>  		return 0;
>  	}

Hmm, we removed the pm_idle_safe logic which took care of that in
older kernel versions :(

        if (!cx || acpi_idle_suspend) {
                if (pm_idle_save)
                        pm_idle_save();
                else
                        acpi_safe_halt();
                return;
        }

That's what took care of the broadcast on those AMD C1E machines as
well.

But yeah, that cpu_relax() loop is probably fine for the suspend path.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/