linux-kernel - Re: [PATCH 1/1] MFD: Add U300 AB3100 core support v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d5443650905191026w22b0ff95j992e09923f55dd0a@mail.gmail.com>
Date:	Tue, 19 May 2009 22:56:16 +0530
From:	Trilok Soni <soni.trilok@...il.com>
To:	Linus Walleij <linus.ml.walleij@...il.com>
Cc:	Mike Rapoport <mike@...pulab.co.il>, linux-kernel@...r.kernel.org,
	sameo@...ux.intel.com, linux-i2c@...r.kernel.org,
	Linus Walleij <linus.walleij@...ricsson.com>
Subject: Re: [PATCH 1/1] MFD: Add U300 AB3100 core support v2

Hi Linus,

On Tue, May 19, 2009 at 9:53 PM, Linus Walleij
<linus.ml.walleij@...il.com> wrote:
> Hm I shouldn't been so trigger-happy as to send v3 out so soon... :-/
>
> Thanks for you quick review Mike!
>
> 2009/5/19 Mike Rapoport <mike@...pulab.co.il>:
>
>>> +     /* Set a pointer back to the container in device data */
>>> +     for (i = 0; i < ARRAY_SIZE(ab3100_platform_devs); i++)
>>> +             platform_set_drvdata(ab3100_platform_devs[i], ab3100_local);
>>> +
>>> +     /* Register the platform devices */
>>> +     platform_add_devices(ab3100_platform_devs,
>>> +                          ARRAY_SIZE(ab3100_platform_devs));
>>
>> If you register sub-devices this way, they won't appear as ab3100 children.
>
> I'll set the parent in the first loop then (will test that this works) because I
> really like that device table. (Similar to how the board setup does things.)
>

I don't know but why people are not encouraging to use mfd_xxx apis
here? Lot's of drivers are available under drivers/mfd, but only
couple of them are using real mfd_xxx apis? Is there anything missing
in those apis?

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/