linux-kernel - Re: [PATCH] Remove indirect variable usage at arch/x86/kernel/tsc.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200905192054.00377.elendil@planet.nl>
Date:	Tue, 19 May 2009 20:53:57 +0200
From:	Frans Pop <elendil@...net.nl>
To:	Subrata Modak <subrata@...ux.vnet.ibm.com>
Cc:	x86@...nel.org, sachinp@...ux.vnet.ibm.com, hpa@...or.com,
	andi@...stfloor.org, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, mingo@...hat.com,
	subrata@...ux.vnet.ibm.com, balbir@...ux.vnet.ibm.com
Subject: Re: [PATCH] Remove indirect variable usage at arch/x86/kernel/tsc.c

Subrata Modak wrote:
> 640         if (!(freq->flags & CPUFREQ_CONST_LOOPS))
> 641 #ifdef CONFIG_SMP
> 642                 lpj = &cpu_data(freq->cpu).loops_per_jiffy;
> 643 #else
> 644         lpj = &boot_cpu_data.loops_per_jiffy;
> 645 #endif

No comments on your patch, but it might be good to also fix the incorrect 
indentation here: line 644 needs an extra tab.

Cheers,
FJP
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/