linux-kernel - Re: [PATCH] istallion: add missing _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A124514.2090609@snapgear.com>
Date:	Tue, 19 May 2009 15:35:16 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Mike Frysinger <vapier@...too.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] istallion: add missing __devexit marking

Hi Mike,

Mike Frysinger wrote:
> The remove member of the pci_driver stli_pcidriver uses __devexit_p(),
> so the remove function itself should be marked with __devexit.  Even
> more so considering the probe function is marked with __devinit.
> 
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> CC: Greg Ungerer <gerg@...inux.org>

Looks ok to me:

Acked-by: Greg Ungerer <gerg@...inux.org>


> ---
>  drivers/char/istallion.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c
> index fff19f7..e8392c2 100644
> --- a/drivers/char/istallion.c
> +++ b/drivers/char/istallion.c
> @@ -3785,7 +3785,7 @@ err:
>  	return retval;
>  }
>  
> -static void stli_pciremove(struct pci_dev *pdev)
> +static void __devexit stli_pciremove(struct pci_dev *pdev)
>  {
>  	struct stlibrd *brdp = pci_get_drvdata(pdev);
>  

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/