linux-kernel - Re: [PATCH] Acer Aspire One Fan Control

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cone.1242715674.319169.6240.1000@arca>
Date:	Tue, 19 May 2009 08:47:54 +0200
From:	Peter Feuerer <peter@...e.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Borislav Petkov <petkovbb@...glemail.com>,
	LKML <linux-kernel@...r.kernel.org>, lenb@...nel.org,
	Matthew Garrett <mjg59@...f.ucam.org>,
	Maxim Levitsky <maximlevitsky@...il.com>
Subject: Re: [PATCH] Acer Aspire One Fan Control

Hi Joe,

Joe Perches writes:

>> +#define acerhdf_printk(loglevel, fmt, args...) \
>> +	printk(loglevel "acerhdf: " fmt, ## args);
>> +
>> +#define acerhdf_notice(fmt, args...) \
>> +	acerhdf_printk(KERN_NOTICE, fmt, ## args);
>> +
>> +#define acerhdf_error(fmt, args...) \
>> +	acerhdf_printk(KERN_ERR, fmt, ## args);
> 
> Could you please not create new prefixes for printk?
> 
> I think:
> 
> #define pr_fmt(fmt) "acerhdf:" fmt
> and use of pr_err and pr_notice would be better.

I could do that. Just curious, is there any deeper reason? Or does it just feel wrong in some matter?

best regards,
--peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/