linux-kernel - Re: [PATCH 01/19] Add XHFC support for embedded Speech-Design board to hfcmulti

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87y6ssnr5v.fsf@basil.nowhere.org>
Date:	Wed, 20 May 2009 09:56:44 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Karsten Keil <keil@...systems.de>
Cc:	linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	i4ldeveloper@...tserv.isdn4linux.de
Subject: Re: [PATCH 01/19] Add XHFC support for embedded Speech-Design board to hfcmulti

Karsten Keil <keil@...systems.de> writes:


> --- a/drivers/isdn/hardware/mISDN/hfc_multi.h
> +++ b/drivers/isdn/hardware/mISDN/hfc_multi.h
> @@ -18,6 +18,46 @@
>  #define	PCI_ENA_MEMIO	0x02
>  
>  /*
> + * Defines for the SDG embedded board using the XHFC-4SU chip
> + */
> +#ifdef CONFIG_8xx

This seems like a awfully generic name for a (likely global) CONFIG. Can you
add a descriptive prefix?

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/