linux-kernel - Re: [PATCH] x86: don't map io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 May 2009 09:58:29 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: don't map io_apic two times.


* Yinghai Lu <yinghai@...nel.org> wrote:

> mp_register_ioapic() already map it.
> 
> [ Impact: don't map io apic address again ]
> 
> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
> 
> ---
>  arch/x86/kernel/apic/io_apic.c |    7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> Index: linux-2.6/arch/x86/kernel/apic/io_apic.c
> ===================================================================
> --- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c
> +++ linux-2.6/arch/x86/kernel/apic/io_apic.c
> @@ -4162,7 +4162,12 @@ fake_ioapic_page:
>  				alloc_bootmem_pages(PAGE_SIZE);
>  			ioapic_phys = __pa(ioapic_phys);
>  		}
> -		set_fixmap_nocache(idx, ioapic_phys);
> +		/*
> +		 * when acpi ioapic is used, mp_register_ioapic() map
> +		 * ioapic_phys already
> +		 */
> +		if (!acpi_ioapic)
> +			set_fixmap_nocache(idx, ioapic_phys);

The change is correct, but i'm not sure we want to do this - the 
acpi_ioapic flag might change its meaning (and then break this code 
subtly) and this is bootup code so doing the mapping twice should be 
no issue.

If it were some expensive initialization i'd agree, but here it's 
really just a couple of instructions and an INVLPG.

Hm?

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/