>From 81eabcf5ca618e2453d97a8822bc6b00fdad81c2 Mon Sep 17 00:00:00 2001 From: Jens Axboe Date: Wed, 20 May 2009 10:53:44 +0200 Subject: [PATCH 3/3] writeback: mm/backing-dev.c:bdi_start_fn() should use bh disabling locks bdi_lock is grabbed from softirq context, so we need to always use bh disabling spinlocks. All the other callsites are OK, but this one missed the _bh() postfix. Signed-off-by: Jens Axboe --- mm/backing-dev.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/backing-dev.c b/mm/backing-dev.c index d45251f..60578bc 100644 --- a/mm/backing-dev.c +++ b/mm/backing-dev.c @@ -365,9 +365,9 @@ static int bdi_start_fn(void *ptr) /* * Make us discoverable on the bdi_list again */ - spin_lock(&bdi_lock); + spin_lock_bh(&bdi_lock); list_add_tail_rcu(&bdi->bdi_list, &bdi_list); - spin_unlock(&bdi_lock); + spin_unlock_bh(&bdi_lock); ret = bdi_writeback_task(wb); -- 1.6.3.9.g6345