linux-kernel - Re: [PATCH] mmc_spi: use EILSEQ for possible transmission errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090520120851.49783a8e@mjolnir.ossman.eu>
Date:	Wed, 20 May 2009 12:08:51 +0200
From:	Pierre Ossman <pierre@...man.eu>
To:	David Brownell <david-b@...bell.net>
Cc:	Wolfgang Mües <wolfgang.mues@...rswald.de>,
	"Matt Fleming" <matt@...sole-pimps.org>,
	"Pierre Ossman" <drzeus@...eus.cx>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Mike Frysinger" <vapier.adi@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mmc_spi: use EILSEQ for possible transmission errors

On Wed, 20 May 2009 02:20:46 -0700
David Brownell <david-b@...bell.net> wrote:

> On Wednesday 20 May 2009, Wolfgang Mües wrote:
> > R1_SPI_COM_CRC is a transmission error - no doubt. Mapping to EILSEQ is OK.
> > 
> > R1_SPI_ERASE_SEQ and R1_SPI_ERASE_RESET are responses to a sector erase 
> > command. block.c is not sending such commands, so block.c can safely assume 
> > that each such response is a transmission error.
> 
> Hmm, would hope that's not a long-term plan.  Remember that the
> firmware in the card can leverage "that's erased" knowledge for
> things like wear leveling.  SSDs and other storage devices would
> likewise benefit from such knowledge.  I'm quite certain there's
> been discussion about adding support for that in the block layer.
> 

It's already in AFAIK. I even had code for hooking it up to mmc_block.
But it didn't produce any measurable results so I never merged it.

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)