linux-kernel - Re: [PATCH 01/19] Add XHFC support for embedded Speech-Design board to hfcmulti

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090520113813.GE8684@one.firstfloor.org>
Date:	Wed, 20 May 2009 13:38:13 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Karsten Keil <keil@...systems.de>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	i4ldeveloper@...tserv.isdn4linux.de
Subject: Re: [PATCH 01/19] Add XHFC support for embedded Speech-Design board to hfcmulti

Hi Karsten,

> 
> This config is not set by mISDN, it is set by somepowerpc  sub arch.

That still seems like a rather quirky way to do this then, making
drivers dependent on specific architectures. This kind
of thing lead to ifdef jungles in the past, hopefully not done
again in new drivers.

Standard ways to handle this:
- If the driver needs something special only this architecture can
provide make the architecture set a special HAS... config option.
- Provide a special asm include file that is stubbed out
by other architectures.
- Put the arch specific code in another file and make that dependent on the 
HAS_...  symbol in the Makefile.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/