linux-kernel - Re: [PATCH v2 2/2] Intel-IOMMU, intr-remap: source-id checking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1fxf0klm6.fsf@fess.ebiederm.org>
Date:	Wed, 20 May 2009 05:24:49 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Yinghai Lu <yinghai@...nel.org>,
	Joerg Roedel <joerg.roedel@....com>,
	Weidong Han <weidong.han@...el.com>, dwmw2@...radead.org,
	suresh.b.siddha@...el.com, linux-kernel@...r.kernel.org,
	iommu@...ts.linux-foundation.org, kvm@...r.kernel.org
Subject: Re: [PATCH v2 2/2] Intel-IOMMU, intr-remap: source-id checking

Ingo Molnar <mingo@...e.hu> writes:

>> The table of apic information by apic_id also seems wrong.  Don't 
>> we have chip_data or something that should point it that we can 
>> get from the irq?
>
> ->chip_data is already used for io-apic configuration bits - if it's 
> reused then the right way to do it is to extend struct irq_cfg in 
> arch/x86/kernel/apic/io_apic.c.

We are talking about some extra io-apic configuration bits, that
happen to currently be private to dmar.c.

chip_data, handler_data I can never keep those straight except
when I am deep in the code.  What I do know is that encouraging
more arrays of size MAX_IO_APICS seems like the wrong direction.

Which probably means adding the information we need to struct irq_cfg.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/