linux-kernel - Re: [PATCH] tracing: use strlcpy instead of strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A136C2C.1010107@cn.fujitsu.com>
Date:	Wed, 20 May 2009 10:34:20 +0800
From:	Lai Jiangshan <laijs@...fujitsu.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
CC:	Ingo Molnar <mingo@...e.hu>, Jiri Slaby <jirislaby@...il.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Li Zefan <lizf@...fujitsu.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH] tracing: use strlcpy instead of strncpy

Stefan Richter wrote:
> Lai Jiangshan wrote:
>> [Impact] cleanup
> 
> Well, not entirely.
> 
>> --- a/kernel/trace/trace.h
>> +++ b/kernel/trace/trace.h
>> @@ -155,8 +155,8 @@ struct trace_boot_ret {
>>  struct trace_branch {
>>      struct trace_entry    ent;
>>      unsigned            line;
>> -    char            func[TRACE_FUNC_SIZE+1];
>> -    char            file[TRACE_FILE_SIZE+1];
>> +    char            func[TRACE_FUNC_SIZE];
>> +    char            file[TRACE_FILE_SIZE];
>>      char            correct;
>>  };
> 
> (without change of the TRACE_????_SIZE definition)
> 
> Better avoid a categorization of a patch if the change's scope exceeds
> that of the categorization.

I think it's make no sense to change the magic number TRACE_????_SIZE,
I will rewrite my changelog as Frederic suggests.

Thank you very much.

Lai.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/