linux-kernel - Re: [PATCH 1/3] tracing: add __print

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.0905201810300.1080@gandalf.stny.rr.com>
Date:	Wed, 20 May 2009 18:13:37 -0400 (EDT)
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Christoph Hellwig <hch@...radead.org>
cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Li Zefan <lizf@...fujitsu.com>,
	Eduard - Gabriel Munteanu <eduard.munteanu@...ux360.ro>,
	Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: [PATCH 1/3] tracing: add __print_flags for events


On Mon, 18 May 2009, Christoph Hellwig wrote:
> Some small comments:
> 
>  - __print_flags might be a little to generic.  What about trace_print_flags?

The __print_flags is not a macro nor a function. It is similar to 
__field() and __array() and __string(). It is a place holder that will be 
overriden by the ftrace.h magic.

I'll keep it as __print_flags since it follows format with the other tags.

>  - some documentation would help.  I can submit a patch to the
>    trave_events sample module to make use of it once this patch is
>    merged.
>  - Maybe passing an array instead of a list of flag/value pairs would be
>    a tad cleaner?  That would get rid of all the varargs mess and allow
>    to declare that array next to the flags so get less easily out of
>    sync.

OK, this may even save space. By passing by parameters we must load all 
the parameters before calling the function. Even though this is on the 
print side, it is still bloated. I'll convert it to an array.

Thanks,

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/