linux-kernel - Re: [PATCH -tip v6 1/5] x86: instruction decorder API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A1488A2.30706@redhat.com>
Date:	Wed, 20 May 2009 18:48:02 -0400
From:	Masami Hiramatsu <mhiramat@...hat.com>
To:	Przemysław Pawełczyk <przemyslaw@...elczyk.it>
CC:	Ingo Molnar <mingo@...e.hu>, Steven Rostedt <rostedt@...dmis.org>,
	lkml <linux-kernel@...r.kernel.org>,
	systemtap <systemtap@...rces.redhat.com>,
	kvm <kvm@...r.kernel.org>,
	DLE <dle-develop@...ts.sourceforge.net>,
	Jim Keniston <jkenisto@...ibm.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Vegard Nossum <vegard.nossum@...il.com>,
	Avi Kivity <avi@...hat.com>
Subject: Re: [PATCH -tip v6 1/5] x86: instruction decorder API

Przemysław Pawełczyk wrote:
> On Wed, May 20, 2009 at 22:58, Masami Hiramatsu <mhiramat@...hat.com> wrote:
> 
>> Changes from v5:
> 
>> - Use /usr/bin/env to find awk
> 
> This is fine, but not in the below case.
> 
>> --- /dev/null
>> +++ b/arch/x86/scripts/gen-insn-attr-x86.awk
>> @@ -0,0 +1,314 @@
>> +#!/usr/bin/env awk -f
> 
> Depending on multi-argument shebang is IMO bad. In shebang generally
> (but not in all systems) everything after interpreter part is treated
> as the first argument. Therefore executing your gen-insn-attr-x86.awk
> is equivalent to:
> 
> /usr/bin/env 'awk -f' gen-insn-attr-x86.awk
> 
> which is obviously wrong.

Oops, right. Anyway, there is no reason that we make it
executable because it's always called from Makefile.
So, I think just removing that line is better way.

Thank you,

-- 
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America) Inc.
Software Solutions Division

e-mail: mhiramat@...hat.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/