linux-kernel - Re: [PATCH 15/20] sysfs: Kill sysfs_addrm_start and sysfs_addrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A151F59.7020304@kernel.org>
Date:	Thu, 21 May 2009 18:31:05 +0900
From:	Tejun Heo <tj@...nel.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
CC:	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	linux-fsdevel@...r.kernel.org,
	"Eric W. Biederman" <ebiederm@...stanetworks.com>
Subject: Re: [PATCH 15/20] sysfs: Kill sysfs_addrm_start and sysfs_addrm_finish

Eric W. Biederman wrote:
> From: Eric W. Biederman <ebiederm@...ssion.com>
> 
> With lazy inode updates and dentry operations bringing everything
> into sync on demand there is no longer any need to immediately
> update the vfs or grab i_mutex to protect those updates as we
> make changes to sysfs.
> 
> So stop updating the vfs inodes and move what remains of
> sysfs_addrm_start and sysfs_addrm_finsih (just barely more than taking
> the sysfs_mutex) into sysfs_add_one and sysfs_remove_one.
> 
> Signed-off-by: Eric W. Biederman <ebiederm@...stanetworks.com>

This looks so better than the original code.  :-)

Acked-by: Tejun Heo <tj@...nel.org>

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/