linux-kernel - Re: [PATCH 01/20] sysfs: Implement sysfs_rename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac3eb2510905210440p14a09d0r1f9a31bd0ecbb9b6@mail.gmail.com>
Date:	Thu, 21 May 2009 13:40:04 +0200
From:	Kay Sievers <kay.sievers@...y.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Tejun Heo <tj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	linux-fsdevel@...r.kernel.org,
	Benjamin Thery <benjamin.thery@...l.net>,
	Daniel Lezcano <dlezcano@...ibm.com>,
	"Eric W. Biederman" <ebiederm@...stanetworks.com>
Subject: Re: [PATCH 01/20] sysfs: Implement sysfs_rename_link

On Thu, May 21, 2009 at 12:29, Eric W. Biederman <ebiederm@...ssion.com> wrote:
> Kay Sievers <kay.sievers@...y.org> writes:

>> The target string is composed on-demand, and it always points to the
>> same kobject and *targ is not needed, right?
>>
>> Can't we just change the name of the link, instead of removing and
>> re-creating the entire thing, and all these issues go away?
>
> Good point.  It looks like I can generalize sysfs_mv_dir into simply
> being sysfs_rename.  All of the existing logic looks like it can handle
> that.  I will look at doing an incremental patch for that.

Nice, would be great, if that can be made working. It would be much
better than the current logic, and there would be no ordering problem,
like Tejun mentioned, to solve anymore.

As we don't need to change the target for link, maybe:
  sysfs_rename_file(kobj_parent, old_name, new_name);
that can act on symlinks and regular files would be useful?

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/