linux-kernel - Re: [PATCH] remove function audit_receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 21 May 2009 11:06:55 +0800
From:	Li Zefan <lizf@...fujitsu.com>
To:	Zhenwen Xu <helight.xu@...il.com>
CC:	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk,
	eparis@...hat.com
Subject: Re: [PATCH] remove function audit_receive_filter here in kerenl/audit.c

> diff --git a/kernel/audit.c b/kernel/audit.c
> index 9442c35..40fc803 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -790,6 +790,7 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
>  		}
>  		/* fallthrough */
>  	case AUDIT_LIST:
> +	case AUDIT_LIST_RULES:
>  		err = audit_receive_filter(msg_type, NETLINK_CB(skb).pid,
>  					   uid, seq, data, nlmsg_len(nlh),
>  					   loginuid, sessionid, sid);
> @@ -807,12 +808,6 @@ static int audit_receive_msg(struct sk_buff *skb, struct nlmsghdr *nlh)
>  			audit_log_end(ab);
>  			return -EPERM;
>  		}
> -		/* fallthrough */

This patch is obviously wrong.

> -	case AUDIT_LIST_RULES:
> -		err = audit_receive_filter(msg_type, NETLINK_CB(skb).pid,
> -					   uid, seq, data, nlmsg_len(nlh),
> -					   loginuid, sessionid, sid);
> -		break;
>  	case AUDIT_TRIM:
>  		audit_trim_trees();
>  

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/