linux-kernel - Re: [PATCH 08/38] pidns 2/2: rewrite copy_pid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090522091451.GC22601@cr0.nay.redhat.com>
Date:	Fri, 22 May 2009 17:14:51 +0800
From:	Amerigo Wang <xiyou.wangcong@...il.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org,
	torvalds@...ux-foundation.org, xemul@...allels.com,
	orenl@...columbia.edu, serue@...ibm.com, dave@...ux.vnet.ibm.com,
	mingo@...e.hu
Subject: Re: [PATCH 08/38] pidns 2/2: rewrite copy_pid_ns()

On Fri, May 22, 2009 at 08:55:02AM +0400, Alexey Dobriyan wrote:
>copy_pid_ns() is a perfect example of a case where unwinding leads to more
>code and makes it less clear. Watch the diffstat.
>

Fully agreed...

>Signed-off-by: Alexey Dobriyan <adobriyan@...il.com>

Reviewed-by: WANG Cong <xiyou.wangcong@...il.com>

Btw, which tree is this patch against? Looks like not linus-tree.


>---
> kernel/pid_namespace.c |   18 +++---------------
> 1 files changed, 3 insertions(+), 15 deletions(-)
>
>diff --git a/kernel/pid_namespace.c b/kernel/pid_namespace.c
>index 495d5de..821722a 100644
>--- a/kernel/pid_namespace.c
>+++ b/kernel/pid_namespace.c
>@@ -116,23 +116,11 @@ static void destroy_pid_namespace(struct pid_namespace *ns)
> 
> struct pid_namespace *copy_pid_ns(unsigned long flags, struct pid_namespace *old_ns)
> {
>-	struct pid_namespace *new_ns;
>-
>-	BUG_ON(!old_ns);
>-	new_ns = get_pid_ns(old_ns);
> 	if (!(flags & CLONE_NEWPID))
>-		goto out;
>-
>-	new_ns = ERR_PTR(-EINVAL);
>+		return get_pid_ns(old_ns);
> 	if (flags & CLONE_THREAD)
>-		goto out_put;
>-
>-	new_ns = create_pid_namespace(old_ns);
>-
>-out_put:
>-	put_pid_ns(old_ns);
>-out:
>-	return new_ns;
>+		return ERR_PTR(-EINVAL);
>+	return create_pid_namespace(old_ns);
> }
> 
> void free_pid_ns(struct kref *kref)
>-- 
>1.5.6.5
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/