linux-kernel - Re: [PATCH] MMC: Add 400ms to CAFE SD controller resume path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090522135150.7e0716d6@mjolnir.ossman.eu>
Date:	Fri, 22 May 2009 13:51:50 +0200
From:	Pierre Ossman <pierre@...man.eu>
To:	dsaxena@...xity.net
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MMC: Add 400ms to CAFE SD controller resume path

On Wed, 13 May 2009 20:05:56 +0000
Deepak Saxena <dsaxena@...xity.net> wrote:

> 
> The CAFE SD controller takes a long time to completely resume
> and w/o this patch, we do not redetect an existing card but
> instead detect it as a new one. Even with MMC_UNSAFE_RESUME
> enabled, this leads to the partition table on the device being
> wiped out.
>     
> See http://dev.laptop.org/ticket/6532 for gory details.
> 
> Signed-off-by: Deepak Saxena <dsaxena@...top.org>
> 

Reading through that report, I don't believe you properly worked around
the bug. You only avoid bug 1339, but that's only mildly related.

What this workaround does is to make sure that MMC_UNSAFE_RESUME
actually works. But if you change cards during suspend, the VFS bug
should reappear and you'll corrupt the partition table.

And as for 1339, has there been any more work done on why this problem
doesn't appear in OFW? I'd be a lot happier if we could make things
work without artificial delays.

RGds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)