linux-kernel - Re: drivers/ide/ide-core: Convert printk's to pr_<foo> and dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <200905222022.03294.bzolnier@gmail.com>
Date:	Fri, 22 May 2009 20:22:02 +0200
From:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, linux-ide@...r.kernel.org,
	Sergei Shtylyov <sshtylyov@...mvista.com>,
	Krzysztof Halasa <khc@...waw.pl>,
	Borislav Petkov <petkovbb@...il.com>
Subject: Re: drivers/ide/ide-core: Convert printk's to pr_<foo> and dev_<foo>

On Monday 18 May 2009 22:11:26 Joe Perches wrote:
> Standardize printk's by mostly mechanical conversions of
> printk(KERN_<foo> to pr_<foo>(.  The KERN_DEBUG uses are
> not done, deferred until a more standard mechanism exists
> 
> Standardize pr_<foo> logging uses of drive->name and hwif->name
> to use dev_<foo>.

Looks fine but please:

* change the order of patches

  Converting to pr_ in patch #1 just to convert to dev_ in patch #2 was
  fine as an intermediate step but now that we have patch #2 you can:
  - apply #1 + #2, revert (ignoring rejects) #1 and generate new #1
  - on top of new #1 apply (ignoring rejects) old #1 to obtain new #2

  It should be pretty simple/quick to do (especially using quilt)...

* push ">80 chars lines" change to patch #3

  TBH this change is "a can of worms" (breaks automatic checking with
  checkpatch.pl, creates precedent, makes code more difficult to work
  on for some people) so I would prefer that we together try to improve
  code areas identified by such patch before considering applying it.

* make sure that this patchset applies to ide-2.6.git/for-next
  (or linux-next since it contains the above tree)

PS (answering your question) patch #2 is correct in using hwif->gendev
and not hwif->dev -- the latter points to host's device

Thanks.
Bart
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/