linux-kernel - Re: [PATCH 2/2] firewire: core: add sysfs attribute for easier udev rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A172131.5010005@s5r6.in-berlin.de>
Date:	Sat, 23 May 2009 00:03:29 +0200
From:	Stefan Richter <stefanr@...6.in-berlin.de>
To:	linux1394-devel@...ts.sourceforge.net
CC:	linux-hotplug@...r.kernel.org, linux-kernel@...r.kernel.org,
	Kay Sievers <kay.sievers@...y.org>
Subject: Re: [PATCH 2/2] firewire: core: add sysfs attribute for easier udev
 rules

Stefan Richter wrote:
> +	while (fw_csr_iterator_next(&ci, &key, &value)) {
> +		if (key != (CSR_UNIT | CSR_DIRECTORY))
> +			continue;
> +		i += units_sprintf(&buf[i], ci.p + value - 1);
> +		if (i >= PAGE_SIZE - (8 + 1 + 8 + 1))
> +			break;
> +	}
> +	up_read(&fw_device_rwsem);
> +
> +	sprintf(&buf[i ? i - 1 : 0], "\n");

Rather:
	if (i)
		buf[i - 1] = '\n';
> +
> +	return i;
> +}
-- 
Stefan Richter
-=====-==--= -=-= =-===
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/