linux-kernel - Re: [PATCH 25/20] sysfs: Only support removing emtpy sysfs directories.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ac3eb2510905231427x62efaecfod2b11472fcdbcc21@mail.gmail.com>
Date:	Sat, 23 May 2009 23:27:32 +0200
From:	Kay Sievers <kay.sievers@...y.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	linux-kernel@...r.kernel.org, Tejun Heo <tj@...nel.org>,
	Cornelia Huck <cornelia.huck@...ibm.com>,
	linux-fsdevel@...r.kernel.org,
	"Eric W. Biederman" <ebiederm@...stanetworks.com>
Subject: Re: [PATCH 25/20] sysfs: Only support removing emtpy sysfs 
	directories.

On Sat, May 23, 2009 at 22:13, Eric W. Biederman <ebiederm@...ssion.com> wrote:
> From: Eric W. Biederman <ebiederm@...ssion.com>
>
> I have looked and I have not found a single legitimate case today where
> we remove sysfs directories with anything in them.  The only case I have
> found to date was a bug.  It was a problem of ownership.  The files in
> the directory where not owned by the directory itself.   Leaving open
> the potential for double deletion of the directory contents.
>
> Signed-off-by: Eric W. Biederman <ebiederm@...stanetworks.com>

Sounds good to me. We should try that, and see if there was any valid
use case we didn't think of, and if not, it's good to do what this
patch does.

Acked-by: Kay Sievers <kay.sievers@...y.org>

Thanks,
Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/