linux-kernel - Re: [PATCH] sparseirq: Enable early irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090523125748.GB23042@elte.hu>
Date:	Sat, 23 May 2009 14:57:48 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Paul Mundt <lethal@...ux-sh.org>, Yinghai Lu <yinghai@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mel@....ul.ie>, linux-kernel@...r.kernel.org,
	Pekka Enberg <penberg@...helsinki.fi>
Subject: Re: [PATCH] sparseirq: Enable early irq_desc allocation.


* Paul Mundt <lethal@...ux-sh.org> wrote:

> On Thu, May 21, 2009 at 01:26:26PM -0700, Yinghai Lu wrote:
> > can you check tip?
> > we change _cpu to node already.
> > 
> > also only sh have after_bootmem now.
> > arch/sh/mm/init.c:int after_bootmem = 0;
> > arch/sh/mm/init.c:      after_bootmem = 1;
> > arch/sh/mm/ioremap_64.c:        extern int after_bootmem;
> > arch/sh/mm/ioremap_64.c:        if (after_bootmem) {
> > include/linux/mm.h:extern int after_bootmem;
> > 
> > for x86 we have bootmem_state ...
> > arch/x86/include/asm/page_types.h:enum bootmem_state {
> > arch/x86/include/asm/page_types.h:extern enum bootmem_state bootmem_state;
> > arch/x86/kernel/setup.c:        bootmem_state = DURING_BOOTMEM;
> > arch/x86/mm/init.c:enum bootmem_state bootmem_state = BEFORE_BOOTMEM;
> > arch/x86/mm/init.c:     if (bootmem_state == BEFORE_BOOTMEM)
> > arch/x86/mm/init.c:     if (bootmem_state == BEFORE_BOOTMEM)
> > arch/x86/mm/init.c:     if (bootmem_state == BEFORE_BOOTMEM && !start) {
> > arch/x86/mm/init.c:     if (bootmem_state == BEFORE_BOOTMEM &&
> > arch/x86/mm/init.c:     if (bootmem_state == BEFORE_BOOTMEM)
> > 
> > Andrew,
> > do we need to move bootmem_state back to linux/mm.h?
> 
> No need, I just switched to slab_is_available() in the respin. Here is
> v2, against -tip:

thanks.

I'm a bit unhappy about allocators here (and this is not your 
fault). There's not two but _three_ states for allocation: bootmem, 
pagealloc, kmalloc. There is a (short) stage during bootup where 
kmalloc is not enabled yet and bootmem is already deactivated. If we 
ever use slab_is_available() in such a state it will blow up.

Fixing all this allocator bootstrapping mess we have in Linux is a 
lot larger project though.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/