linux-kernel - Re: [PATCH] forget a blankspace before 'name'

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 23 May 2009 09:13:36 -0400
From:	Eric Paris <eparis@...hat.com>
To:	Zhenwen Xu <helight.xu@...il.com>
Cc:	linux-kernel@...r.kernel.org, viro@...iv.linux.org.uk
Subject: Re: [PATCH] forget a blankspace before 'name'

On Sat, 2009-05-23 at 18:10 +0800, Zhenwen Xu wrote:
> here should add some space before "name="

NAK.

/* This is a helper-function to print the escaped d_path */
void audit_log_d_path(struct audit_buffer *ab, const char *prefix,
                      struct path *path)
{
        char *p, *pathname;

        if (prefix)
                audit_log_format(ab, " %s", prefix);

Look there, a space before the prefix.




> Signed-off-by: Zhenwen Xu <helight.xu@...il.com>
> ---
>  kernel/auditsc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index 7d6ac7c..aa0428e 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -1478,7 +1478,7 @@ static void audit_log_exit(struct audit_context *context, struct task_struct *ts
>  			case 0:
>  				/* name was specified as a relative path and the
>  				 * directory component is the cwd */
> -				audit_log_d_path(ab, "name=", &context->pwd);
> +				audit_log_d_path(ab, " name=", &context->pwd);
>  				break;
>  			default:
>  				/* log the name's directory component */
> -- 
> 1.5.6.5
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/