[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20090523151845.GB2642@infradead.org>
Date: Sat, 23 May 2009 11:18:45 -0400
From: Christoph Hellwig <hch@...radead.org>
To: Zhaolei <zhaolei@...fujitsu.com>
Cc: Frederic Weisbecker <fweisbec@...il.com>,
Steven Rostedt <rostedt@...dmis.org>,
Ingo Molnar <mingo@...e.hu>, Tom Zanussi <tzanussi@...il.com>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ftrace: Add task_comm support for trace_event
On Sat, May 23, 2009 at 11:16:28AM -0400, Christoph Hellwig wrote:
> On Thu, May 21, 2009 at 03:08:46PM +0800, Zhaolei wrote:
> > <...>-2289 [000] 526276.724790: sched_switch: task bash:2289 [120] ==> sshd:2287 [120]
>
> we should have a space after the colon. Also wouldn't it be better
> to place task->commit close to the pid in the output?
Sorry, please ignore this mail, it doesn't make any sense :) I took
the old example tracer output for the added comm information. The patch
does look good to me.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists