linux-kernel - Re: Re: [PATCH v2 2/2] ftrace: clean up of using ftrace_event_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090525083207.GB6215@nowhere>
Date:	Mon, 25 May 2009 10:32:08 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Zhaolei <zhaolei@...fujitsu.com>
Cc:	Steven Rostedt <rostedt@...dmis.org>, Ingo Molnar <mingo@...e.hu>,
	Tom Zanussi <tzanussi@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Re: [PATCH v2 2/2] ftrace: clean up of using
	ftrace_event_enable_disable()

On Mon, May 25, 2009 at 01:34:26PM +0800, Zhaolei wrote:
> Frederic Weisbecker wrote:
> > On Fri, May 22, 2009 at 06:06:20PM +0800, Zhaolei wrote:
> >> Always use tracing_stop_cmdline_record() to enable/disable a event.
> >>
> >> Impact: cleanup, no functionality changed
> >>
> >> Signed-off-by: Zhao Lei <zhaolei@...fujitsu.com>
> >> ---
> >>  kernel/trace/trace_events.c |   44 +++++++++++++-----------------------------
> >>  1 files changed, 14 insertions(+), 30 deletions(-)
> >>
> >> diff --git a/kernel/trace/trace_events.c b/kernel/trace/trace_events.c
> >> index df35e5e..16ef47a 100644
> >> --- a/kernel/trace/trace_events.c
> >> +++ b/kernel/trace/trace_events.c
> >> @@ -76,26 +76,9 @@ static void trace_destroy_fields(struct ftrace_event_call *call)
> >>  
> >>  #endif /* CONFIG_MODULES */
> >>  
> >> -static void ftrace_clear_events(void)
> >> -{
> >> -	struct ftrace_event_call *call;
> >> -
> >> -	mutex_lock(&event_mutex);
> >> -	list_for_each_entry(call, &ftrace_events, list) {
> > 
> > 
> > Don't we have a "for_each_event" ?
> 
> Hello, Frederic
> 
> Thanks for your review.
> 
> IMHO, for_each_event is for iter each tracepoints in one module(or kernel),
> but we need to iter whole tracepoints in manage.
> So, list_for_each_entry(call, &ftrace_events, list) maybe better here.
> 
> Thanks
> Zhaolei


Ah yeah, ok.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/