linux-kernel - Re: [PATCH] Re: /proc/uptime idle counter remains at 0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090525122820.044e1e35@skybase>
Date:	Mon, 25 May 2009 12:28:20 +0200
From:	Martin Schwidefsky <schwidefsky@...ibm.com>
To:	Michael Abbott <michael@...neidae.co.uk>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jan Engelhardt <jengelh@...ozas.de>
Subject: Re: [PATCH] Re: /proc/uptime idle counter remains at 0

On Mon, 18 May 2009 14:23:03 +0100 (BST)
Michael Abbott <michael@...neidae.co.uk> wrote:

> diff --git a/fs/proc/uptime.c b/fs/proc/uptime.c
> index 0c10a0b..0f43395 100644
> --- a/fs/proc/uptime.c
> +++ b/fs/proc/uptime.c
> @@ -4,13 +4,19 @@
>  #include <linux/sched.h>
>  #include <linux/seq_file.h>
>  #include <linux/time.h>
> +#include <linux/kernel_stat.h>
>  #include <asm/cputime.h>
> 
>  static int uptime_proc_show(struct seq_file *m, void *v)
>  {
>  	struct timespec uptime;
>  	struct timespec idle;
> -	cputime_t idletime = cputime_add(init_task.utime, init_task.stime);
> +	int len, i;
> +	cputime_t idletime = 0;
> +
> +	for_each_possible_cpu(i) 
> +		idletime = cputime64_add(idletime, kstat_cpu(i).cpustat.idle);
> +	idletime = cputime64_to_clock_t(idletime);
> 
>  	do_posix_clock_monotonic_gettime(&uptime);
>  	monotonic_to_bootbased(&uptime);

I found another problem with this patch: why do you convert the
idletime from cputime_t to clock_t ? The call to cputime_to_timespec
takes a cputime_t and the conversion from cputime to clock_t returns a
value that is way to small on s390. After removing that line it works
for me but I wonder why you added it.

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/