linux-kernel - Re: [PATCH 06/12] writeback: separate the flushing state/task from the bdi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090525103623.GU11363@kernel.dk>
Date:	Mon, 25 May 2009 12:36:24 +0200
From:	Jens Axboe <jens.axboe@...cle.com>
To:	Jan Kara <jack@...e.cz>
Cc:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	chris.mason@...cle.com, david@...morbit.com, hch@...radead.org,
	akpm@...ux-foundation.org, yanmin_zhang@...ux.intel.com
Subject: Re: [PATCH 06/12] writeback: separate the flushing state/task from
	the bdi

On Mon, May 25 2009, Jan Kara wrote:
> On Mon 25-05-09 09:34:41, Jens Axboe wrote:
> > Add a struct bdi_writeback for tracking and handling dirty IO. This
> > is in preparation for adding > 1 flusher task per bdi.
> > 
> > Signed-off-by: Jens Axboe <jens.axboe@...cle.com>
> ...
> >  static int bdi_start_fn(void *ptr)
> >  {
> > -	struct backing_dev_info *bdi = ptr;
> > +	struct bdi_writeback *wb = ptr;
> > +	struct backing_dev_info *bdi = wb->bdi;
> >  	struct task_struct *tsk = current;
> > -
> > -	/*
> > -	 * Add us to the active bdi_list
> > -	 */
> > -	mutex_lock(&bdi_lock);
> > -	list_add(&bdi->bdi_list, &bdi_list);
> > -	mutex_unlock(&bdi_lock);
>   I'm probably missing something but I cannot find where the bdi is added
> to the bdi_list after this patch...

For some reason, that part is now in the following patch. The two hunks
should just be deleted, good catch!

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/