linux-kernel - Re: [PATCH] ieee1394: eth1394: use "firewire%d" instead of "eth%d" as interface name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ac3eb2510905250357qd72b0eel7cec2bd56f12f71@mail.gmail.com>
Date:	Mon, 25 May 2009 12:57:54 +0200
From:	Kay Sievers <kay.sievers@...y.org>
To:	Matthias Schwarzott <zzam@...too.org>
Cc:	linux-hotplug@...r.kernel.org,
	Stefan Richter <stefanr@...6.in-berlin.de>,
	Christian Kujau <lists@...dbynature.de>,
	linux-kernel@...r.kernel.org,
	linux1394-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH] ieee1394: eth1394: use "firewire%d" instead of "eth%d" as 
	interface name

On Mon, May 25, 2009 at 10:33, Matthias Schwarzott <zzam@...too.org> wrote:
> On Sonntag, 24. Mai 2009, Stefan Richter wrote:
>> Christian Kujau wrote at LKML:
>> > If the patch will be accepted at all and it's not too late to ask: I'd
>> > vote for fw%d as well, "firefire" just looks too long, for me at least.
>>
>> I think I'll leave the driver as it is.
>> As I just noticed, we would lose interface renaming by udev.
>> From udev/extras/rule_generator/75-persistent-net-generator.rules:
>>
>>   # device name whitelist
>>   KERNEL!="eth*|ath*|wlan*[0-9]|msh*|ra*|sta*|ctc*|lcs*|hsi*",
>> GOTO="persistent_net_generator_end"
>>
>> Besides, if we can we should avoid fw%d because this will clash with
>> udev rules which match KERNEL=="fw*", as in
>> udev/rules/redhat/40-redhat.rules.
>
> I suggest a subsystem match here, or generally some
> SUBSYSTEM!="net", GOTO="end_of_file"
> around almost all rule files that should not match on network interfaces, as
> users can rename them to almost all crazy names.
>
> @Kay: Perhaps it could simplify some rulesets to have a special jump target or
> option to skip entiere rules files.

Not sure, if Fedora is using this rule file, there seems a lot of old
stuff in it. But the rule should be ignored for device without a
device node, when SYMLINK is given in the rule.

Kay
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/