linux-kernel - Re: [PATCH 1/3] kbuild: handle non-existing options in scripts/config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090525131144.GZ846@one.firstfloor.org>
Date:	Mon, 25 May 2009 15:11:44 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Michal Marek <mmarek@...e.cz>
Cc:	Andi Kleen <andi@...stfloor.org>, Sam Ravnborg <sam@...nborg.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/3] kbuild: handle non-existing options in scripts/config

> -replace() {
> -	sed -i -e "$@" $FN
> +# set_var name value [before-var]
> +set_var() {
> +	awk -vvar="$1" -vnew="$2" -vbefore="$3" '

This seems rather complicated compared to what was there before.

I would just cmp the output file to the input file and if they are
the same then add it at the end with a echo

> +	}
> +	' "$FN" >"$FN.tmp"

This should be a &&, otherwise you risk removing the output file
on ctrl-c

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/