linux-kernel - Re: [RFC PATCH 3/X] ptrace: introduce the empty "struct ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090525155038.GA10431@redhat.com>
Date:	Mon, 25 May 2009 17:50:38 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Roland McGrath <roland@...hat.com>,
	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 3/X] ptrace: introduce the empty "struct
	ptrace_task"

On 05/25, Ingo Molnar wrote:
>
> * Oleg Nesterov <oleg@...hat.com> wrote:
>
> > --- PTRACE/include/linux/sched.h~3_STRUCT	2009-05-24 21:29:04.000000000 +0200
> > +++ PTRACE/include/linux/sched.h	2009-05-24 22:14:41.000000000 +0200
> > @@ -1201,6 +1201,7 @@ struct task_struct {
> >  	struct list_head sibling;	/* linkage in my parent's children list */
> >  	struct task_struct *group_leader;	/* threadgroup leader */
> >
> > +	struct ptrace_task *ptrace_task;
> >  	/*
> >  	 * ptraced is the list of tasks this task is using ptrace on.
> >  	 * This includes both natural children and PTRACE_ATTACH targets.
>
> the naming sucks.
>
> Please use 'struct ptrace_context' and '*ptrace_ctx' instead.

As always, I agree with any naming. Will re-name in V2.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/