linux-kernel - Re: [RFC PATCH 5/X] ptrace: mv task_struct->ptrace ptrace_task->pt_flags, kill ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090525160351.GB10431@redhat.com>
Date:	Mon, 25 May 2009 18:03:51 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Roland McGrath <roland@...hat.com>,
	Christoph Hellwig <hch@...radead.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 5/X] ptrace: mv task_struct->ptrace
	ptrace_task->pt_flags, kill ptrace_link()

On 05/25, Ingo Molnar wrote:
>
> * Oleg Nesterov <oleg@...hat.com> wrote:
>
> >  struct ptrace_task {
> > +	unsigned long	pt_flags;
> >  };
>
> > -	return task->ptrace;
> > +	return unlikely(task->ptrace_task) ?
> > +		task->ptrace_task->pt_flags : 0;
>
> Please no pt_ prefixes. It is abundantly clear from the
> '->ptrace_ctx' portion already that it's about ptrace - the rest
> should be a straightforward minimalistic naming - i.e.
> ->ptrace_ctx->flags.

OK, will rename.

But note that you can't use cscope to find the usage of ->flags. Even
grep is not reliable, unless the code always adds 'ptrace' to the name
of the pointer.

> Also, is the conditional necessary? We should not be calling ptrace
> methods on tasks with no ptrace context.

It is mostly used as is_task_ptraced() actually, that is why ptrace context
can be NULL.

This in turn needs cleanups, will be addressed further.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/