linux-kernel - Re: USB/DVB - Old Technotrend TT-connect S-2400 regression tracked down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A1AE705.2050809@unsolicited.net>
Date:	Mon, 25 May 2009 19:44:21 +0100
From:	David <david@...olicited.net>
To:	Alan Stern <stern@...land.harvard.edu>
CC:	Pekka Enberg <penberg@...helsinki.fi>, linux-media@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	dbrownell@...rs.sourceforge.net, leonidv11@...il.com,
	Greg KH <gregkh@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: USB/DVB - Old Technotrend TT-connect S-2400 regression tracked
  down

David wrote:
> Alan Stern wrote:
>   
>> Okay, here's a patch for you to try.  It refreshes the toggle setting 
>> in a linked but otherwise idle QH when a new URB is queued.
>>
>> Alan Stern
>>
>>
>> Index: usb-2.6/drivers/usb/host/ehci-q.c
>> ===================================================================
>> --- usb-2.6.orig/drivers/usb/host/ehci-q.c
>> +++ usb-2.6/drivers/usb/host/ehci-q.c
>> @@ -88,7 +88,7 @@ static inline void
>>  qh_update (struct ehci_hcd *ehci, struct ehci_qh *qh, struct ehci_qtd *qtd)
>>  {
>>  	/* writes to an active overlay are unsafe */
>> -	BUG_ON(qh->qh_state != QH_STATE_IDLE);
>> +	BUG_ON(qh->qh_state != QH_STATE_IDLE && !list_empty(&qh->qtd_list));
>>  
>>  	qh->hw_qtd_next = QTD_NEXT(ehci, qtd->qtd_dma);
>>  	qh->hw_alt_next = EHCI_LIST_END(ehci);
>> @@ -971,7 +971,13 @@ static struct ehci_qh *qh_append_tds (
>>  		/* can't sleep here, we have ehci->lock... */
>>  		qh = qh_make (ehci, urb, GFP_ATOMIC);
>>  		*ptr = qh;
>> +	} else if (list_empty(&qh->qtd_list)) {
>> +		/* There might have been a Clear-Halt while the QH
>> +		 * was linked but empty.
>> +		 */
>> +		qh_refresh(ehci, qh);
>>  	}
>> +
>>  	if (likely (qh != NULL)) {
>>  		struct ehci_qtd	*qtd;
>>  
>>
>>   
>>     
> No luck I'm afraid (although there now appear to be 2 timeouts, not
> one). I'm going to follow up on the laptop and get a USB log.
>   
USB log post-patch attached. Thanks for all the effort so far!

David

Download attachment "postpatch.log.bz2" of type "application/x-bzip" (12697 bytes)