linux-kernel - Re: [PATCH -next] cpc-usb: fix PROC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A1A23E4.3070604@ems-wuensche.com>
Date:	Mon, 25 May 2009 06:51:48 +0200
From:	Sebastian Haas <haas@...-wuensche.com>
To:	Randy Dunlap <rdunlap@...otime.net>
CC:	LKML <linux-kernel@...r.kernel.org>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, Greg KH <gregkh@...e.de>
Subject: Re: [PATCH -next] cpc-usb: fix PROC_FS dependency

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Randy Dunlap schrieb:
> Randy Dunlap wrote:
>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>
>> The proper way to check for and enforce a kconfig symbol
>> dependency is via Kconfig files, not by using #error in
>> a source file followed by 9 other compile errors.
>>
>> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
>> Cc: Sebastian Haas <haas@...-wuensche.com>
>> ---
>>  drivers/staging/cpc-usb/Kconfig       |    2 +-
>>  drivers/staging/cpc-usb/cpc-usb_drv.c |   10 +---------
>>  2 files changed, 2 insertions(+), 10 deletions(-)
>>
>> --- linux-next-20090522.orig/drivers/staging/cpc-usb/cpc-usb_drv.c
>> +++ linux-next-20090522/drivers/staging/cpc-usb/cpc-usb_drv.c
>> @@ -27,12 +27,8 @@
>>  #include <linux/completion.h>
>>  #include <asm/uaccess.h>
>>  #include <linux/usb.h>
>> -
>>  #include <linux/version.h>
>> -
>> -#ifdef CONFIG_PROC_FS
>> -#   include <linux/proc_fs.h>
>> -#endif
>> +#include <linux/proc_fs.h>
>>  
>>  #include "cpc.h"
>>  
>> @@ -57,10 +53,6 @@ MODULE_LICENSE("GPL v2");
>>  #define USB_CPCUSB_M16C_PRODUCT_ID    0x0888
>>  #define USB_CPCUSB_LPC2119_PRODUCT_ID 0x0444
>>  
>> -#ifndef CONFIG_PROC_FS
>> -#error "PROCFS needed"
>> -#endif
>> -
>>  #define CPC_USB_PROC_DIR     CPC_PROC_DIR "cpc-usb"
>>  
>>  static struct proc_dir_entry *procDir;
>> --- linux-next-20090522.orig/drivers/staging/cpc-usb/Kconfig
>> +++ linux-next-20090522/drivers/staging/cpc-usb/Kconfig
>> @@ -1,4 +1,4 @@
>>  config USB_CPC
>>  	tristate "CPC CAN USB driver"
>> -	depends on USB
>> +	depends on USB && PROC_FS
>>  	default n
> 
> BTW, I'm surprised that there is no NET or CAN dependency here.
Yes, you are right. But there are no dependencies yet. As soon as
the driver starts to support SocketCAN, we need to add this
dependency.

- --
Mit freundlichen Gruessen/Best Regards,

Sebastian Haas
Software Entwicklung/Software Development

Phone: +49-9451-9432-22
Fax  : +49-9451-9432-12
Email: haas@...-wuensche.com
Web  : www.ems-wuensche.com
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkoaI9sACgkQpqRB8PJG7XzKAgCfWhjQeeFG+qXLoOQHM0hy0sw2
iK8An08cPNYEP5qEA/ex5KGjZm71keBq
=Fxlt
-----END PGP SIGNATURE-----
-- 
EMS Dr. Thomas Wuensche e.K.
Sonnenhang 3
85304 Ilmmuenster
HRA Neuburg a.d. Donau, HR-Nr. 70.106
Phone: +49-8441-490260
Fax  : +49-8441-81860
http://www.ems-wuensche.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/