linux-kernel - Re: [PATCH] [7/16] POISON: Add basic support for poisoned pages in fault handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090526131838.GE846@one.firstfloor.org>
Date:	Tue, 26 May 2009 15:18:38 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Hidehiro Kawai <hidehiro.kawai.ez@...achi.com>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, x86@...nel.org,
	Satoshi OSHIMA <satoshi.oshima.fk@...achi.com>,
	Taketoshi Sakuraba <taketoshi.sakuraba.hc@...achi.com>
Subject: Re: [PATCH] [7/16] POISON: Add basic support for poisoned pages in fault handler

On Tue, May 26, 2009 at 09:55:26PM +0900, Hidehiro Kawai wrote:
> > +			print_bad_pte(vma, address, pte, NULL);
> > +			ret = VM_FAULT_OOM;
> > +		}
> >  		goto out;
> >  	}
> >  	delayacct_set_flag(DELAYACCT_PF_SWAPIN);
> > @@ -2451,6 +2459,9 @@
> >  		/* Had to read the page from swap area: Major fault */
> >  		ret = VM_FAULT_MAJOR;
> >  		count_vm_event(PGMAJFAULT);
> > +	} else if (PagePoison(page)) {
> > +		ret = VM_FAULT_POISON;
> 
> delayacct_clear_flag(DELAYACCT_PF_SWAPIN) would be needed here.

Thanks for the review. Added.

Must have been a forward port error, I could swear that wasn't there
yet when I wrote this originally :)

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/