linux-kernel - Re: [PATCH] Fix build warning and avoid checking for mem != null twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 May 2009 16:19:46 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Nikanth Karthikesan <knikanth@...e.de>
Cc:	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Pavel Emelyanov <xemul@...nvz.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] Fix build warning and avoid checking for mem != null 
	twice

On Tue, May 26, 2009 at 4:14 PM, Nikanth Karthikesan <knikanth@...e.de> wrote:
> Fix build warning, "mem_cgroup_is_obsolete defined but not used" when
> CONFIG_DEBUG_VM is not set. Also avoid checking for !mem twice.
>
> Signed-off-by: Nikanth Karthikesan <knikanth@...e.de>

I also sent a patch to fix this but yours is much nicer.

Acked-by: Pekka Enberg <penberg@...helsinki.fi>

>
> ---
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 01c2d8f..420fc61 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -314,14 +314,6 @@ static struct mem_cgroup *try_get_mem_cgroup_from_mm(struct mm_struct *mm)
>        return mem;
>  }
>
> -static bool mem_cgroup_is_obsolete(struct mem_cgroup *mem)
> -{
> -       if (!mem)
> -               return true;
> -       return css_is_removed(&mem->css);
> -}
> -
> -
>  /*
>  * Call callback function against all cgroup under hierarchy tree.
>  */
> @@ -932,7 +924,7 @@ static int __mem_cgroup_try_charge(struct mm_struct *mm,
>        if (unlikely(!mem))
>                return 0;
>
> -       VM_BUG_ON(!mem || mem_cgroup_is_obsolete(mem));
> +       VM_BUG_ON(!mem || css_is_removed(&mem->css));
>
>        while (1) {
>                int ret;
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/