linux-kernel - [RFC] kernel/lockdep: use BFS(breadth-first search) algorithm to search target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 May 2009 21:54:42 +0800
From:	Ming Lei <tom.leiming@...il.com>
To:	mingo@...e.hu, a.p.zijlstra@...llo.nl
Cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: [RFC] kernel/lockdep: use BFS(breadth-first search) algorithm to
 search target


Hi,All

Currently lockdep uses recursion DFS(depth-first search) algorithm to
search target in checking lock circle(check_noncircular()),irq-safe
-> irq-unsafe(check_irq_usage()) and irq inversion when adding a new
lock dependency. I plan to replace the current DFS with BFS, based on
the following consideration:

	1,no loss of efficiency, no matter DFS or BFS, the running time
	are O(V+E) (V is vertex count, and E is edge count of one
	graph);

	2,BFS may be easily implemented by circular queue and consumes
	much less kernel stack space than DFS for DFS is implemented by
	recursion, we know kernel stack is very limited, eg. 4KB.

	3, The shortest path can be obtained by BFS if the target is
	found, but can't be got by DFS. By the shortest path, we can
	shorten the lock dependency chain and help to troubleshoot lock
	problem easier than before.

Any suggestions, objections or viewpoint?

Thanks,
-- 
Lei Ming
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/